Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): updated the example of with-styled-components #70796

Merged
merged 7 commits into from
Oct 4, 2024
Merged

chore(examples): updated the example of with-styled-components #70796

merged 7 commits into from
Oct 4, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

This PR updates the with-styled-components example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Updated the routing for / & /about files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

The following actions were performed as part of this PR:

  • Ran pnpm prettier-check with no issues found.
  • Executed the pnpm check-examples script.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Oct 4, 2024
@ijjk
Copy link
Member

ijjk commented Oct 4, 2024 •
edited by samcx
Loading

Allow CI Workflow Run

  • approve CI run for commit: 566c392

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Oct 4, 2024 •
edited by samcx
Loading

Allow CI Workflow Run

  • approve CI run for commit: 566c392

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Oct 4, 2024 •
edited by samcx
Loading

Allow CI Workflow Run

  • approve CI run for commit: 4b87c8c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review October 4, 2024 15:23
@samcx samcx self-requested a review October 4, 2024 18:06
samcx
samcx approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit 7474f10 into vercel:canary Oct 4, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sam-Phillemon9493 @ijjk @samcx